Fix jumping to read marker for events without tiles #4830
Conversation
It is possible for your read marker to be set to an event without a tile (like a reaction). We would still render the read marker at the position of those events in the timeline, even though there's no matching tile, which breaks a core assumption of jump to read marker path: it assumes that if the read marker node is present in the DOM, then there must also be an event tile with a scroll token matching the event ID. This fixes the situation by no longer attempting to draw a read marker for events without tiles. Fixes element-hq/element-web#10975
|
Won't this mean to green line at all when you jump to unread? |
Yes, it does mean that if your read marker points to an event without a tile, now you wouldn't have a read marker line when jumping. It's a bit of edge case, since Saying all this out loud though, I suppose it would be better to always have the green line as before, and instead just fix the scrolling code to go to the right place? |
|
Removing from queue for now for more changes. |
|
Replaced by a more sensible #4860 |
It is possible for your read marker to be set to an event without a tile (like a
reaction). We would still render the read marker at the position of those events
in the timeline, even though there's no matching tile, which breaks a core
assumption of jump to read marker path: it assumes that if the read marker node
is present in the DOM, then there must also be an event tile with a scroll token
matching the event ID.
This fixes the situation by no longer attempting to draw a read marker for
events without tiles.
Fixes element-hq/element-web#10975